From: Greg KH <gregkh@linuxfoundation.org>
To: Pol Eyschen <poleyschen@gmail.com>
Cc: sachin.kamat@linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, ufimtseva@gmail.com
Subject: Re: [PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend)
Date: Fri, 7 Feb 2014 10:01:57 -0800 [thread overview]
Message-ID: <20140207180157.GA7677@kroah.com> (raw)
In-Reply-To: <1389821834-17601-1-git-send-email-poleyschen@gmail.com>
On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote:
> Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs
>
> Signed-off-by: Pol Eyschen <poleyschen@gmail.com>
> ---
> drivers/staging/ced1401/ced_ioc.c | 483 +++++++++++++++++++++----------------
> 1 file changed, 271 insertions(+), 212 deletions(-)
>
> diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
> index bf532b1..94a361d 100644
> --- a/drivers/staging/ced1401/ced_ioc.c
> +++ b/drivers/staging/ced1401/ced_ioc.c
> @@ -40,8 +40,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
> {
> dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
> pdx->sCurrentState);
> - if (pdx->sCurrentState == U14ERR_TIME) /* Do nothing if hardware in trouble */
> - return;
> + if (pdx->sCurrentState == U14ERR_TIME)
> + return; /* Do nothing if hardware in trouble */
That's really not a good cleanup, is it?
And this patch no longer applies to my tree, care to fix it up and
resend?
thanks,
greg k-h
prev parent reply other threads:[~2014-02-07 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 21:37 Pol Eyschen
2014-02-07 18:01 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207180157.GA7677@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=poleyschen@gmail.com \
--cc=sachin.kamat@linaro.org \
--cc=ufimtseva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome