mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Imre Deak <imre.deak@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernfs: skip lockdep annotation always if ignore_lockdep is set
Date: Fri, 7 Feb 2014 14:53:13 -0500	[thread overview]
Message-ID: <20140207195313.GB8833@htj.dyndns.org> (raw)
In-Reply-To: <1391802421-7829-1-git-send-email-imre.deak@intel.com>

On Fri, Feb 07, 2014 at 09:47:01PM +0200, Imre Deak wrote:
> We skip lockdep annotations for sysfs attributes with ignore_lockdep
> set. An exception is kernfs_deactivate where we annotate even in this
> case. Since the lockdep map key needed for the annotation is not
> initialized whenever ignore_lockdep is set, we'll get a warning for
> the uninitialized key.
> 
> Note that this happens since,
> 
> commit 517e64f57883bd63c5a4ab8b3d0d3ed68c55d0cf
> Author: Tejun Heo <tj@kernel.org>
> Date:   Thu Nov 28 14:54:29 2013 -0500
> 
> Before this change we had a valid key even in case of ignore_lockdep, so
> the annotation in kernfs_deactivate worked, or at least didn't produce
> the above warning. Fix this by skipping the annotation whenever
> ignore_lockdep is set.
> 
> The actual attribute triggering the bug was 'delete_device' in
> drivers/i2c/i2c-core.c, for the backtrace see the reference below.

I think Greg already has about the same patch queued.

  http://lkml.kernel.org/g/20140129170403.GJ30842@htj.dyndns.org

Thanks.

-- 
tejun

  reply	other threads:[~2014-02-07 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 19:47 Imre Deak
2014-02-07 19:53 ` Tejun Heo [this message]
2014-02-07 22:17   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207195313.GB8833@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=imre.deak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®