From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbaBJX5W (ORCPT ); Mon, 10 Feb 2014 18:57:22 -0500 Received: from rere.qmqm.pl ([89.167.52.164]:37500 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752362AbaBJX5S (ORCPT ); Mon, 10 Feb 2014 18:57:18 -0500 X-Greylist: delayed 490 seconds by postgrey-1.27 at vger.kernel.org; Mon, 10 Feb 2014 18:57:18 EST Date: Tue, 11 Feb 2014 00:49:04 +0100 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Shuah Khan Cc: rjw@rjwysocki.net, chris@printf.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, shuahkhan@gmail.com Subject: Re: [RFT][PATCH 08/12] mmc: change cb710-mmc platform power management to use dev_pm_ops Message-ID: <20140210234904.GA542@rere.qmqm.pl> References: <5393e4bd34e5667b7d00fa09c9d5bee0f68d659f.1392040068.git.shuah.kh@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5393e4bd34e5667b7d00fa09c9d5bee0f68d659f.1392040068.git.shuah.kh@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 09:12:31AM -0700, Shuah Khan wrote: > Change cb710-mmc platform driver to register pm ops using dev_pm_ops instead > of legacy pm_ops. .pm hooks call existing legacy suspend and resume interfaces > by passing in the right pm state. [all the patch cut] Aaah, a bit mechanical - this change, isn't it? The suspend/resume callbacks just clears IRQ mask in the device in case it got undefined during sleep state. So the proper change here is to squash all the functions in one, and point all of the hooks to it. With the change you have my ack. BTW, you could move cb710_mmc_suspend() (or whatever you'll call it) to one ifdef block with cb710_mmc_dev_pm_ops. Best Regards, Michał Mirosław