From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbaBKXes (ORCPT ); Tue, 11 Feb 2014 18:34:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42307 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752AbaBKXer (ORCPT ); Tue, 11 Feb 2014 18:34:47 -0500 Date: Tue, 11 Feb 2014 15:34:45 -0800 From: Andrew Morton To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, rdunlap Subject: Re: [PATCH 1/1] kernel: panic: display reason at end + pr_emerg Message-Id: <20140211153445.c03bf3b266880ff0a174cee6@linux-foundation.org> In-Reply-To: <20140208154522.aa927a34df7b018c5eee47ef@skynet.be> References: <20140208154522.aa927a34df7b018c5eee47ef@skynet.be> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 8 Feb 2014 15:45:22 +0800 Fabian Frederick wrote: > Currently, booting without initrd specified on 80x25 screen > gives a call trace followed by atkbd : Spurious ACK. > Original message ("VFS: Unable to mount root fs") is not available. > Of course this could happen in other situations... > > -This patch displays panic reason after call trace which could help > lot of people even if it's not the very last line on screen. Fair enough. Hate it when that happens! > -Converting all panic.c printk(KERN_EMERG to pr_emerg( You missed a couple. --- a/kernel/panic.c~kernel-panicc-display-reason-at-end-pr_emerg-fix +++ a/kernel/panic.c @@ -275,8 +275,7 @@ unsigned long get_taint(void) void add_taint(unsigned flag, enum lockdep_ok lockdep_ok) { if (lockdep_ok == LOCKDEP_NOW_UNRELIABLE && __debug_locks_off()) - printk(KERN_WARNING - "Disabling lock debugging due to kernel taint\n"); + pr_warn("Disabling lock debugging due to kernel taint\n"); set_bit(flag, &tainted_mask); } @@ -381,8 +380,7 @@ late_initcall(init_oops_id); void print_oops_end_marker(void) { init_oops_id(); - printk(KERN_WARNING "---[ end trace %016llx ]---\n", - (unsigned long long)oops_id); + pr_warn("---[ end trace %016llx ]---\n", (unsigned long long)oops_id); } /* _