From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: dbx500/abx500: root out hardcoded IRQ assignments
Date: Tue, 11 Feb 2014 17:39:33 +0000 [thread overview]
Message-ID: <20140211173933.GW13533@sirena.org.uk> (raw)
In-Reply-To: <1392114599-481-1-git-send-email-linus.walleij@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On Tue, Feb 11, 2014 at 11:29:59AM +0100, Linus Walleij wrote:
> I've been ambivalent on how to look up the IRQ resource for the
> AB8500 from the device tree (as it is hanging off the main GIC
> interrupt controller rather than the PRCMU) and eventually ended
> up with this solution. I experimented with modifying mfd-core.c
> to add resources from the device tree, but I didn't like the
> result, it seems MFD cells should get their resources exclusively
> from the parent instantiating the cell, so I ended up with this.
> Maybe Broonie has ideas about this too?
This looks reasonably sensible to me. The way irqdomains seem to want
you to encapsulate this stuff is that the internal interrupts of the
chip get an irqdomain and then the children get their resources relative
to that, normally using the MFD helpers to map the hwirqs in the domain
to Linux interrupt numbers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-11 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 10:29 Linus Walleij
2014-02-11 11:40 ` Lee Jones
2014-02-11 11:55 ` Linus Walleij
2014-02-11 17:39 ` Mark Brown [this message]
2014-02-13 13:11 ` Linus Walleij
2014-02-13 13:17 ` Lee Jones
2014-02-14 10:46 ` Linus Walleij
2014-02-14 16:54 ` Arnd Bergmann
2014-02-24 13:40 ` Linus Walleij
2014-02-24 13:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211173933.GW13533@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome