From: Will Deacon <will.deacon@arm.com>
To: Weng Meiling <wengmeiling.weng@huawei.com>
Cc: Robert Richter <rric@kernel.org>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
"wangnan0@huawei.com" <wangnan0@huawei.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
Huang Qiang <h.huangqiang@huawei.com>,
"sdu.liu@huawei.com" <sdu.liu@huawei.com>
Subject: Re: [PATCH] oprofile: check whether oprofile perf enabled in op_overflow_handler()
Date: Tue, 11 Feb 2014 18:05:12 +0000 [thread overview]
Message-ID: <20140211180512.GO8693@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20140211155207.GK8693@mudshark.cambridge.arm.com>
On Tue, Feb 11, 2014 at 03:52:07PM +0000, Will Deacon wrote:
> On Tue, Feb 11, 2014 at 04:33:51AM +0000, Weng Meiling wrote:
> > Is there any progress on this work? Because this is important for me.
> > Sorry for trouble you.
>
> Oops, I totally forgot about this. Does the below patch work for you?
[...]
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 56003c6edfd3..6fcc293d77a4 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -237,6 +237,8 @@ void perf_sample_event_took(u64 sample_len_ns)
> u64 local_samples_len;
> u64 allowed_ns = ACCESS_ONCE(perf_sample_allowed_ns);
>
> + pr_info("perf_sample_event_took(%llu ns)\n", sample_len_ns);
> +
> if (allowed_ns == 0)
> return;
Ignore this hunk, it was there as a debugging aid. Testing the other half of
the patch would be useful though!
Will
next prev parent reply other threads:[~2014-02-11 18:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 7:49 Weng Meiling
2013-12-30 9:06 ` Weng Meiling
2014-01-13 8:45 ` Robert Richter
2014-01-14 1:52 ` Weng Meiling
2014-01-14 15:05 ` Robert Richter
2014-01-15 2:02 ` Weng Meiling
2014-01-15 10:24 ` Robert Richter
2014-01-16 1:09 ` Weng Meiling
2014-01-16 9:33 ` Weng Meiling
2014-01-16 11:52 ` Robert Richter
2014-01-16 19:36 ` Will Deacon
2014-01-17 3:37 ` Weng Meiling
2014-02-11 4:33 ` Weng Meiling
2014-02-11 15:52 ` Will Deacon
2014-02-11 18:05 ` Will Deacon [this message]
2014-02-15 2:41 ` Weng Meiling
2014-02-17 10:08 ` Will Deacon
2014-02-17 11:39 ` Weng Meiling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140211180512.GO8693@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=h.huangqiang@huawei.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=sdu.liu@huawei.com \
--cc=wangnan0@huawei.com \
--cc=wengmeiling.weng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome