mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: Subject: Warning in workqueue.c
Date: Fri, 14 Feb 2014 11:38:40 -0500	[thread overview]
Message-ID: <20140214163840.GH31544@htj.dyndns.org> (raw)
In-Reply-To: <20140214162854.GO27965@twins.programming.kicks-ass.net>

On Fri, Feb 14, 2014 at 05:28:54PM +0100, Peter Zijlstra wrote:
> On Fri, Feb 14, 2014 at 11:25:56AM -0500, Tejun Heo wrote:
> > Hey, we now even keep normal kthreads across cpu down/ups. :)
> 
> Well, we keep them, but parked, they're not allowed to run.

Yeah, that's true.  In the long term, I think we'll need to have
better distinction between the work items which actually need affinity
for correctness and which is just doing it as an optimization.  It's
already happening now in a rather ad-hoc way with WQ_POWER_EFFICIENT.
Anyways, once we actually make that distinction clearly, it should
probably be possible to flush all per-cpu ones and keep them parked
across offline.  Right now, we have mixture of the two and the
knowledge is only present in cpu_down callbacks of each user making it
difficult to do that.

Thanks.

-- 
tejun

  reply	other threads:[~2014-02-14 16:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 14:39 Jason J. Herne
2014-02-07 16:51 ` Tejun Heo
2014-02-07 17:55   ` Jason J. Herne
2014-02-07 19:36     ` Tejun Heo
2014-02-10 15:32       ` Jason J. Herne
2014-02-10 23:17         ` Tejun Heo
2014-02-12 15:18           ` Jason J. Herne
2014-02-13  3:02             ` Lai Jiangshan
2014-02-13  3:31             ` Lai Jiangshan
2014-02-13 17:58               ` Jason J. Herne
2014-02-13 20:41                 ` Tejun Heo
2014-02-14 14:56                   ` Jason J. Herne
2014-02-14 14:58                     ` Tejun Heo
2014-02-14 16:09                   ` Peter Zijlstra
2014-02-14 16:25                     ` Tejun Heo
2014-02-14 16:28                       ` Peter Zijlstra
2014-02-14 16:38                         ` Tejun Heo [this message]
2014-02-24 15:01                       ` Jason J. Herne
2014-02-24 18:35                         ` Tejun Heo
2014-02-25 10:37                           ` Peter Zijlstra
2014-03-10 14:37                             ` Jason J. Herne
2014-03-17 14:51                               ` Jason J. Herne
2014-03-17 15:16                               ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214163840.GH31544@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®