From: Mark Brown <broonie@kernel.org>
To: Milo Kim <milo.kim@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 10/10] Documentation: Add device tree bindings for TI LMU devices
Date: Fri, 14 Feb 2014 20:50:27 +0000 [thread overview]
Message-ID: <20140214205027.GT4451@sirena.org.uk> (raw)
In-Reply-To: <1392359564-7205-1-git-send-email-milo.kim@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
On Fri, Feb 14, 2014 at 03:32:44PM +0900, Milo Kim wrote:
> Bindings for TI LMU, backlight, LM3631 regulator and LM3633 LED are added.
Ah, sorry - I didn't notice that there were several different binding
documents in the patch.
> @@ -0,0 +1,49 @@
> +TI LMU LM3631 regulator device tree bindings
> +
> +Required properties:
> + - compatible: "ti,lm3631-regulator"
> +
> +Optional properties:
> + - regulator-name
> + - regulator-min-microvolt
> + - regulator-max-microvolt
> + - regulator-always-on
> + - regulator-boot-on
> +
> + For those properties, please refer to:
> + Documentation/devicetree/bindings/regulator/regulator.txt
This doesn't correspond to the example which says that there is an
optional property "regulators" which can contain regualators lcd_boost,
lcd_vpos and lcd_vneg. It's also better to not enumerate all the
standard properties but just refer to the generic document (as you do).
That avoids confusion if new properties are added to the generic
regulator bindings.
The actual binding is fine, it's just the way it's documented.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-15 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 6:32 Milo Kim
2014-02-14 10:06 ` Mark Rutland
2014-02-17 7:15 ` Milo Kim
2014-02-14 20:44 ` Mark Brown
2014-02-14 20:50 ` Mark Brown [this message]
2014-02-17 7:15 ` Milo Kim
2014-02-18 1:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214205027.GT4451@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®