mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@debian.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900
Date: Mon, 17 Feb 2014 00:04:08 +0100	[thread overview]
Message-ID: <20140216230408.GA4376@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1391603582-11371-1-git-send-email-sre@debian.org>

On Wed 2014-02-05 13:33:02, Sebastian Reichel wrote:
> Without enabling the workaround for ARM errata 430973 thumb
> compiled userland crashes randomly on the Nokia N900.
> 
> Signed-off-by: Sebastian Reichel <sre@debian.org>

Reviewed-by: Pavel Machek <pavel@ucw.cz>


> +static void __init nokia_n900_legacy_init(void)
> +{
> +	hsmmc2_internal_input_clk();
> +
> +	if (omap_type() == OMAP2_DEVICE_TYPE_SEC) {
> +		if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) {
> +			pr_info("RX-51: Enabling ARM errata 430973 workaround\n");
> +			/* set IBE to 1 */
> +			rx51_secure_update_aux_cr(BIT(6), 0);
> +		} else {
> +			pr_warning("RX-51: Not enabling ARM errata 430973 workaround\n");
> +		}

I'd use higher loglevel there, and added "thumb binaries can now crash
randomly, and can crash the system" ... or something like that, if you
are going to send new version of the patch.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2014-02-16 23:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 12:33 Sebastian Reichel
2014-02-05 13:12 ` Pali Rohár
2014-02-05 16:31   ` Sebastian Reichel
2014-02-05 16:38     ` Pali Rohár
2014-02-05 17:17       ` Sebastian Reichel
2014-02-05 20:30         ` Ivaylo Dimitrov
2014-02-06  0:39           ` Sebastian Reichel
2014-02-05 20:42         ` Pali Rohár
2014-02-06  0:25           ` Sebastian Reichel
2014-02-16 23:04 ` Pavel Machek [this message]
2014-02-17 21:30 ` [PATCHv2] " Sebastian Reichel
2014-02-21 23:08   ` Tony Lindgren
2014-03-01 21:32   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140216230408.GA4376@amd.pavel.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@debian.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®