From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: "Håvard Skinnemoen" <hskinnemoen@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
tim.c.chen@linux.intel.com, liuj97@gmail.com,
"David Miller" <davem@davemloft.net>,
rostedt@goodmis.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: avr32: include: asm: Kbuild: add generic "vga.h"
Date: Mon, 17 Feb 2014 10:52:32 +0100 [thread overview]
Message-ID: <20140217095232.GB20665@samfundet.no> (raw)
In-Reply-To: <5300A2A6.3010801@gmail.com>
Around Sun 16 Feb 2014 19:36:06 +0800 or thereabout, Chen Gang wrote:
> Need add generic "vga.h", or can not pass building for allmodconfig,
> the related error:
>
> CC [M] drivers/gpu/drm/drm_irq.o
> In file included from include/linux/vgaarb.h:34,
> from drivers/gpu/drm/drm_irq.c:42:
> include/video/vga.h:22:21: error: asm/vga.h: No such file or directory
Does this really makes sense for an architecture that only supports framebuffer?
I even recall doing something like this in the past, but the change probably
fell between chairs.
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/include/asm/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/avr32/include/asm/Kbuild b/arch/avr32/include/asm/Kbuild
> index 8b398ff..00a0f3c 100644
> --- a/arch/avr32/include/asm/Kbuild
> +++ b/arch/avr32/include/asm/Kbuild
> @@ -19,4 +19,5 @@ generic-y += scatterlist.h
> generic-y += sections.h
> generic-y += topology.h
> generic-y += trace_clock.h
> +generic-y += vga.h
> generic-y += xor.h
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2014-02-17 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 11:36 Chen Gang
2014-02-17 9:52 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217095232.GB20665@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=davem@davemloft.net \
--cc=gang.chen.5i5j@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome