mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Jan Beulich <JBeulich@suse.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Issue a warning if number of present CPUs > maxcpus and CONFIG_HOTPLUG=n
Date: Mon, 17 Feb 2014 19:51:11 -0300	[thread overview]
Message-ID: <20140217225111.GA2561@khazad-dum.debian.net> (raw)
In-Reply-To: <20140217203102.7af3fd28@hananiah.suse.cz>

On Mon, 17 Feb 2014, Petr Tesarik wrote:
> > I'd rather no warnings were printed at all (user asked for that nr_cpus,
> > there is no reason to warn him about it),
> >[...]
> 
> Agreed. This needs some cleanup.
> 
> This code used to check against NR_CPUS, which is a compile-time
> constant, so the warning was printed when the user booted a kernel
> incapable of using all available CPUs in the system. And this was a
> good thing, because there was no (easy) way to find out this constant
> from a given kernel binary.
> 
> I can post a clean-up patch that doesn't issue any warnings for user
> overrides (but does issue warnings for exceeding hard-coded kernel
> limits).

That'd be really nice.  Thank you!

> But I'll do it separately and only after I know if the current patch
> gets accepted or not. ;-)

:-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

      reply	other threads:[~2014-02-17 22:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 14:02 Petr Tesarik
2014-02-16 17:11 ` Borislav Petkov
2014-02-17  8:34 ` Jan Beulich
2014-02-17 10:04   ` Petr Tesarik
2014-02-17 13:40     ` Henrique de Moraes Holschuh
2014-02-17 14:16       ` Petr Tesarik
2014-02-17 19:07         ` Henrique de Moraes Holschuh
2014-02-17 19:31           ` Petr Tesarik
2014-02-17 22:51             ` Henrique de Moraes Holschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217225111.GA2561@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=JBeulich@suse.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ptesarik@suse.cz \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®