From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <21cnbao@gmail.com>
Cc: ohad@wizery.com, linux-kernel@vger.kernel.org,
workgroup.linux@csr.com, Wei Chen <Wei.Chen@csr.com>,
Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH] drivers/rpmsg/virtio_rpmsg_bus.c: fix the return value of rpmsg_init
Date: Tue, 18 Feb 2014 14:19:34 -0800 [thread overview]
Message-ID: <20140218141934.902737c24a0b46ef42e6ea9a@linux-foundation.org> (raw)
In-Reply-To: <1392624815-20759-1-git-send-email-21cnbao@gmail.com>
On Mon, 17 Feb 2014 16:13:34 +0800 Barry Song <21cnbao@gmail.com> wrote:
> From: Wei Chen <Wei.Chen@csr.com>
>
> rpmsg_init() always return ERROR code or random integer now, this patch fixes
> it.
>
> ...
>
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -1096,9 +1096,10 @@ static int __init rpmsg_init(void)
> if (ret) {
> pr_err("failed to register virtio driver: %d\n", ret);
> bus_unregister(&rpmsg_bus);
> + return ret;
> }
>
> - return ret;
> + return 0;
> }
Look more closely. This patch has no effect...
next prev parent reply other threads:[~2014-02-18 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 8:13 Barry Song
2014-02-18 22:19 ` Andrew Morton [this message]
2014-02-19 0:54 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218141934.902737c24a0b46ef42e6ea9a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=Wei.Chen@csr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®