mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: x86 perf's dTLB-load-misses broken on IvyBridge?
Date: Wed, 19 Feb 2014 07:23:54 -0800	[thread overview]
Message-ID: <20140219152354.GW12219@tassilo.jf.intel.com> (raw)
In-Reply-To: <5303E8BF.9030107@linux.intel.com>

On Tue, Feb 18, 2014 at 03:11:59PM -0800, Dave Hansen wrote:
> I noticed that perf's dTLB-load-misses even t isn't working on my
> Ivybridge system:
> 
> >  Performance counter stats for 'system wide':
> > 
> >                  0      dTLB-load-misses                                             [100.00%]
> >             48,570      dTLB-store-misses                                            [100.00%]
> >            202,573      iTLB-loads                                                   [100.00%]
> >            271,546      iTLB-load-misses          #  134.05% of all iTLB cache hits 
> 
> But it works on a SandyBridge system that I have.
> 
> arch/x86/kernel/cpu/perf_event_intel.c seems to use the same tables for
> SandyBridge and IvyBridge, so they both use the
> 'MEM_UOP_RETIRED.ALL_LOADS' event:
> 
> >  [ C(DTLB) ] = {
> >         [ C(OP_READ) ] = {
> >                 [ C(RESULT_ACCESS) ] = 0x81d0, /* MEM_UOP_RETIRED.ALL_LOADS */
> >                 [ C(RESULT_MISS)   ] = 0x0108, /* DTLB_LOAD_MISSES.CAUSES_A_WALK */
> >         },
> 
> But that event looks to be unsupported on this CPU:

I thought you wanted the miss event? 

That would be the second entry.

ALL_LOADS is the access event. it works for me, both raw and perf cooked 
(not sure why the two numbers are different though)

% perf stat -e dTLB-loads,r81d0 -a sleep 1

 Performance counter stats for 'system wide':

        12,685,064 dTLB-loads                                                   [100.00%]
        13,277,367 r81d0                                                       

       1.001420860 seconds time elapsed

Miss event count too:

perf stat -e dTLB-load-misses,dTLB-load  -a sleep 1

 Performance counter stats for 'system wide':

            19,504 dTLB-load-misses          #    0.30% of all dTLB cache hits  [100.00%]
         6,471,308 dTLB-load                                                   

       1.001894328 seconds time elapsed

Same raw:

perf stat -e r0108 -a sleep 1

 Performance counter stats for 'system wide':

            82,285 r0108                                                       

       1.001353060 seconds time elapsed


> > perf stat -a -e cpu/event=0xd0,umask=0x81,name=mem_uops_retired_all_loads/ sleep 1
> > 
> >  Performance counter stats for 'system wide':
> > 
> >    <not supported>      mem_uops_retired_all_loads
> >         50,204,763      mem_uops_retired_all_loads_ps
> 
> But there's a "_ps" version which uses PEBS which does work?

Both works for me on a IvyBridge.

> Should we swap perf_event_intel.c over to use the PEBS version so that
> it works everywhere?

Shouldn't be needed.

PEBS for counting normally doesn't make much sense.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

  parent reply	other threads:[~2014-02-19 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 23:11 Dave Hansen
2014-02-19  8:43 ` Peter Zijlstra
2014-02-19 15:23 ` Andi Kleen [this message]
2014-02-19 15:40 ` x86 perf's dTLB-load-misses broken on IvyBridge? II Andi Kleen
2014-02-19 15:54   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219152354.GW12219@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome