mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [workqueue] BUG: unable to handle kernel paging request at ffff880000798f60
Date: Wed, 19 Feb 2014 14:05:55 -0500	[thread overview]
Message-ID: <20140219190555.GR10134@htj.dyndns.org> (raw)
In-Reply-To: <20140219124614.GM15586@twins.programming.kicks-ass.net>

On Wed, Feb 19, 2014 at 01:46:14PM +0100, Peter Zijlstra wrote:
> On Wed, Feb 19, 2014 at 08:41:22PM +0800, Fengguang Wu wrote:
> > Greetings,
> > 
> > I got the below dmesg and the first bad commit is
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git
> > 
> > commit 84604340d034a074036e86e85c4055a1c7ea5529
> > Author:     Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Tue Feb 11 12:00:36 2014 +0100
> > Commit:     Tejun Heo <tj@kernel.org>
> > CommitDate: Tue Feb 11 10:25:17 2014 -0500
> > 
> >     workqueue: Fix workqueue lockdep name
> >     
> >     Tommi noticed a 'funny' lock class name: "%s#5" from a lock acquired
> >     in process_one_work(). It turns out that commit b196be89cdc14 forgot
> >     to change the lockdep_init_map() when it changed the @lock_name
> >     argument from a string to a format.
> >     
> >     Fixes: b196be89cdc14 ("workqueue: make alloc_workqueue() take printf
> >     fmt and args for name")
> >     
> >     Reported-by: Tommi Rantala <tt.rantala@gmail.com>
> >     Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> >     Signed-off-by: Tejun Heo <tj@kernel.org>
> >     Cc: stable@vger.kernel.org
> 
> I seem to remember tj already having reverted this patch.

Hmmm... right, this shouldn't be in the tree anymore.  Let me check.
Yeap, it's not there anymore.

Thanks.

-- 
tejun

  reply	other threads:[~2014-02-19 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 12:41 Fengguang Wu
2014-02-19 12:42 ` [workqueue] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:710 __lock_acquire() Fengguang Wu
2014-02-19 12:46 ` [workqueue] BUG: unable to handle kernel paging request at ffff880000798f60 Peter Zijlstra
2014-02-19 19:05   ` Tejun Heo [this message]
2014-02-19 12:51 ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219190555.GR10134@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®