From: Drew Richardson <drew.richardson@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnaldo <acme@redhat.com>, Pawel Moll <Pawel.Moll@arm.com>,
Wade Cherry <Wade.Cherry@arm.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: Perf Oops on 3.14-rc2
Date: Wed, 19 Feb 2014 11:37:34 -0800 [thread overview]
Message-ID: <20140219193724.GA27267@dreric01-Precision-T1600> (raw)
In-Reply-To: <20140219162819.GP15586@twins.programming.kicks-ass.net>
On Wed, Feb 19, 2014 at 04:28:19PM +0000, Peter Zijlstra wrote:
> On Tue, Feb 18, 2014 at 10:18:31AM +0000, Will Deacon wrote:
> > On Mon, Feb 10, 2014 at 10:17:59PM +0000, Drew Richardson wrote:
> > > While adding CPU on/offlining support during perf captures I get an
> > > Oops both on ARM as well as my desktop x86_64. Below is a small
> > > program that duplicates the issue.
> >
> > [...]
> >
> > FWIW I can reproduce this easily with -rc3 on my x86 laptop running
> > hackbench in parallel with a tweaked version of your test (using
> > _SC_NPROCESSORS_ONLN instead of _SC_NPROCESSORS_CONF and hotplugging off
> > both CPU2 and CPU3).
> >
>
> OK; found it, or at least, I stopped being able to make my box explode.
>
> Drew, can you try the below and confirm? Its still got all the debug goo
> in too, but *shees* took me long enough.
This works great for me. No Oops or garbage data when a core is
offlined.
> + raw_spin_lock(&ctx->lock);
> + ctx_sched_out(ctx, cpuctx, EVENT_ALL);
> +
> + list_for_each_entry(event, &ctx->event_list, event_entry)
> + event->state = PERF_EVENT_STATE_off;
> +
> + raw_spin_unlock(&ctx->lock);
I changed PERF_EVENT_STATE_off to PERF_EVENT_STATE_OFF.
Drew
prev parent reply other threads:[~2014-02-19 19:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 22:17 Drew Richardson
2014-02-18 10:18 ` Will Deacon
2014-02-18 10:52 ` Peter Zijlstra
2014-02-18 11:03 ` Will Deacon
2014-02-18 10:54 ` Peter Zijlstra
2014-02-18 11:01 ` Will Deacon
2014-02-19 16:28 ` Peter Zijlstra
2014-02-19 18:03 ` Stephane Eranian
2014-02-19 18:36 ` Peter Zijlstra
2014-02-19 19:59 ` Stephane Eranian
2014-02-19 20:24 ` Peter Zijlstra
2014-02-19 19:37 ` Drew Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219193724.GA27267@dreric01-Precision-T1600 \
--to=drew.richardson@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Wade.Cherry@arm.com \
--cc=Will.Deacon@arm.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®