From: Andrew Morton <akpm@linux-foundation.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Mike Frysinger <vapier@gentoo.org>,
Kyungsik Lee <kyungsik.lee@lge.com>, Jiri Slaby <jslaby@suse.cz>,
Eric Paris <eparis@redhat.com>,
Dwight Engen <dwight.engen@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs, kernel: Support disabling the uselib syscall
Date: Fri, 21 Feb 2014 12:16:27 -0800 [thread overview]
Message-ID: <20140221121627.19e5d04dbba25984d4be8a15@linux-foundation.org> (raw)
In-Reply-To: <20140221181103.GA5773@jtriplet-mobl1>
On Fri, 21 Feb 2014 10:11:06 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
> uselib hasn't been used since libc5; glibc does not use it. Support
> turning it off.
>
> When disabled, also omit the load_elf_library implementation from
> binfmt_elf.c, which only uselib invokes.
>
> bloat-o-meter:
> add/remove: 0/4 grow/shrink: 0/1 up/down: 0/-785 (-785)
> function old new delta
> padzero 39 36 -3
> uselib_flags 20 - -20
> sys_uselib 168 - -168
> SyS_uselib 168 - -168
> load_elf_library 426 - -426
>
The patch disables CONFIG_USELIB by default. This important decision
should be mentioned and justified in the changelog, please.
> +#ifdef CONFIG_USELIB
I wonder if CONFIG_SYS_USELIB would be a better identifier. We haven't
done anything consistent here.
next prev parent reply other threads:[~2014-02-21 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 18:11 Josh Triplett
2014-02-21 20:16 ` Andrew Morton [this message]
2014-02-21 20:44 ` Josh Triplett
2014-02-21 21:00 ` [PATCHv2] " Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221121627.19e5d04dbba25984d4be8a15@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dwight.engen@oracle.com \
--cc=eparis@redhat.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=jslaby@suse.cz \
--cc=kyungsik.lee@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=vapier@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®