From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755230AbaBUVrS (ORCPT ); Fri, 21 Feb 2014 16:47:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58632 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbaBUVrR (ORCPT ); Fri, 21 Feb 2014 16:47:17 -0500 Date: Fri, 21 Feb 2014 13:47:16 -0800 From: Andrew Morton To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, dhowells , Joe Perches Subject: Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc Message-Id: <20140221134716.4a030e668c50e274b6c1a695@linux-foundation.org> In-Reply-To: <20140220220039.0a727f1bc423339d69ffca0a@skynet.be> References: <20140220220039.0a727f1bc423339d69ffca0a@skynet.be> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Feb 2014 22:00:39 +0800 Fabian Frederick wrote: > This patch calls zalloc for explicit zero fill and removes all memset 0. > May as well fix the deceitful comment while we're in there. --- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix +++ a/fs/afs/super.c @@ -474,7 +474,7 @@ static void afs_i_init_once(void *_vnode } /* - * allocate an AFS inode struct from our slab cache + * allocate an AFS inode struct */ static struct inode *afs_alloc_inode(struct super_block *sb) { This isn't the most useful comment in the kernel..