From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212AbaBXXFN (ORCPT ); Mon, 24 Feb 2014 18:05:13 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48141 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbaBXXFL (ORCPT ); Mon, 24 Feb 2014 18:05:11 -0500 Date: Mon, 24 Feb 2014 18:05:10 -0500 (EST) Message-Id: <20140224.180510.103916219115440711.davem@davemloft.net> To: f.fainelli@gmail.com Cc: sebastian.hesselbarth@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: add suspend_halted module param From: David Miller In-Reply-To: References: <1393174719-20806-1-git-send-email-sebastian.hesselbarth@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Feb 2014 15:05:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Mon, 24 Feb 2014 10:20:10 -0800 > Hi Sebastian, > > 2014-02-23 8:58 GMT-08:00 Sebastian Hesselbarth > : >> commit 1211ce53077164e0d34641d0ca5fb4d4a7574498 >> ("net: phy: resume/suspend PHYs on attach/detach") >> introduced a feature to suspend PHYs when entering halted state. >> >> Unfortunately, not all bootloaders properly power-up PHYs on reset >> and fail to access ethernet because the PHY is still powered down. >> >> Therefore, we add a boolean module parameter suspend_halted with >> default value of true. Disabling that parameter prevents PHYs from >> being suspended when entering halted state. >> >> Signed-off-by: Sebastian Hesselbarth >> Reported-by: Andrew Lunn >> --- >> Andrew, can you please re-test if disabling the feature does work on >> your board? I tried a bunch of mine, but none failed to power-up the >> PHY in u-boot. > > Would be good to get Andrew's testing on this just to make sure it > solves his problem. Otherwise: > > Acked-by: Florian Fainelli I disagree with using a module parameter for this. Figure out the devices that cannot do this properly, and add an internal flag that this driver sets. Module parameters are terrible.