From: David Miller <davem@davemloft.net>
To: kyle@infradead.org
Cc: bp@alien8.de, nic_swsd@realtek.com, romieu@fr.zoreil.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8169: initialize rtl8169_stats seqlock
Date: Mon, 24 Feb 2014 20:32:40 -0500 (EST) [thread overview]
Message-ID: <20140224.203240.898686891281813790.davem@davemloft.net> (raw)
In-Reply-To: <20140225011228.GC14970@merlin.infradead.org>
From: Kyle McMartin <kyle@infradead.org>
Date: Mon, 24 Feb 2014 20:12:28 -0500
> From: Kyle McMartin <kyle@redhat.com>
>
> Boris reports he's seeing:
>> [ 9.195943] INFO: trying to register non-static key.
>> [ 9.196031] the code is fine but needs lockdep annotation.
>> [ 9.196031] turning off the locking correctness validator.
>> [ 9.196031] CPU: 1 PID: 933 Comm: modprobe Not tainted 3.14.0-rc4+ #1
> with the r8169 driver.
>
> These are occuring because the seqcount embedded in u64_stats_sync on
> 32-bit SMP is uninitialized which is making lockdep unhappy.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
Good catch, applied, thanks Kyle.
next prev parent reply other threads:[~2014-02-25 1:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 23:17 r8169: INFO: trying to register non-static key Borislav Petkov
2014-02-24 23:22 ` Borislav Petkov
2014-02-25 1:12 ` [PATCH] r8169: initialize rtl8169_stats seqlock Kyle McMartin
2014-02-25 1:32 ` David Miller [this message]
2014-02-25 7:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224.203240.898686891281813790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bp@alien8.de \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®