From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "David E. Box" <david.e.box@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org,
srinivas.pandruvada@linux.intel.com, jacob.jun.pan@intel.com
Subject: Re: [PATCH RESEND] x86: iosf_mbi: Provide dummy functions if CONFIG_IOSF_MBI not set
Date: Mon, 24 Feb 2014 13:29:16 +0000 [thread overview]
Message-ID: <20140224132916.69b95bf5@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <530B4767.9010109@zytor.com>
On Mon, 24 Feb 2014 05:21:43 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:
> On 02/24/2014 05:19 AM, One Thousand Gnomes wrote:
> >
> > Other than _available I would have expected all the others to resolve to
> > returning an error or doing a WARN() in the not compiled in case.
> >
>
> WARN() or BUG()?
WARN I think. The usage cases I am aware of don't end up in catastrophic
failure if you get this wrong, but would be annoying to debug if missed.
Alan
next prev parent reply other threads:[~2014-02-24 13:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 23:34 [PATCH] " David E. Box
2014-02-23 1:02 ` [PATCH RESEND] " David E. Box
2014-02-24 13:19 ` One Thousand Gnomes
2014-02-24 13:21 ` H. Peter Anvin
2014-02-24 13:29 ` One Thousand Gnomes [this message]
2014-02-25 2:47 ` [PATCH V2 0/2] x86: IOSF: Add loadable module support David E. Box
2014-02-26 19:40 ` [PATCH V3 " David E. Box
2014-02-28 17:47 ` [PATCH V4 " David E. Box
2014-02-28 18:01 ` H. Peter Anvin
2014-03-01 2:40 ` [PATCH V5 " David E. Box
2014-03-03 7:01 ` Li, Aubrey
2014-03-03 15:58 ` David E. Box
2014-03-03 22:15 ` Li, Aubrey
2014-03-03 23:01 ` David E. Box
2014-03-01 2:40 ` [PATCH V5 1/2] x86: IOSF: add dummy functions for loadable modules David E. Box
2014-03-01 20:34 ` [tip:x86/platform] x86, iosf: Add " tip-bot for David E. Box
2014-03-03 7:21 ` [PATCH V5 1/2] x86: IOSF: add " Li, Aubrey
2014-03-03 12:20 ` One Thousand Gnomes
2014-03-01 2:40 ` [PATCH V5 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y David E. Box
2014-03-03 7:07 ` Li, Aubrey
2014-03-03 16:25 ` David E. Box
2014-02-28 17:47 ` [PATCH V4 1/2] x86: IOSF: add dummy functions for loadable modules David E. Box
2014-02-28 17:47 ` [PATCH V4 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y David E. Box
2014-02-26 19:40 ` [PATCH V3 1/2] x86: IOSF: add dummy functions for loadable modules David E. Box
2014-02-26 19:40 ` [PATCH V3 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y David E. Box
2014-02-27 3:26 ` H. Peter Anvin
2014-02-27 16:50 ` [PATCH RESEND " David E. Box
2014-02-25 2:47 ` [PATCH V2 1/2] x86: IOSF: add dummy functions for loadable modules David E. Box
2014-02-25 2:47 ` [PATCH V2 2/2] x86: IOSF: Change IOSF_MBI Kconfig to default y David E. Box
2014-03-01 20:34 ` [tip:x86/platform] x86, iosf: " tip-bot for David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224132916.69b95bf5@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=david.e.box@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®