From: Mark Brown <broonie@kernel.org>
To: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
Cc: sachin.kamat@linaro.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH 1/1] regulator: mc13xxx: check if DT is enabled
Date: Tue, 25 Feb 2014 20:58:40 +0900 [thread overview]
Message-ID: <20140225115840.GA25940@sirena.org.uk> (raw)
In-Reply-To: <1393318071-13524-1-git-send-email-philippe.retornaz@epfl.ch>
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
On Tue, Feb 25, 2014 at 09:47:51AM +0100, Philippe Rétornaz wrote:
> + if(!pdev->dev.parent->of_node)
> + return -ENODEV;
I know Sachin was going to post a more complete patch here but watch out
for coding style - there should be a space between if and the (.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-02-25 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 13:44 [PATCH 13/16] regulator: mc13xxx: Use of_get_child_by_name Philippe Rétornaz
2014-02-24 14:51 ` Sachin Kamat
2014-02-24 15:07 ` Philippe Rétornaz
2014-02-24 15:10 ` Sachin Kamat
2014-02-25 8:47 ` [PATCH 1/1] regulator: mc13xxx: check if DT is enabled Philippe Rétornaz
2014-02-25 9:12 ` Sachin Kamat
2014-02-25 10:09 ` Philippe Rétornaz
2014-02-25 10:12 ` Sachin Kamat
2014-02-25 11:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225115840.GA25940@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.retornaz@epfl.ch \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®