From: Peter Zijlstra <peterz@infradead.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Ben Segall <bsegall@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED
Date: Tue, 25 Feb 2014 21:52:53 +0100 [thread overview]
Message-ID: <20140225205253.GB18404@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1393328862-19997-1-git-send-email-dietmar.eggemann@arm.com>
On Tue, Feb 25, 2014 at 11:47:42AM +0000, Dietmar Eggemann wrote:
> +++ b/kernel/sched/sched.h
> @@ -630,7 +630,9 @@ struct rq {
> struct llist_head wake_list;
> #endif
>
> +#ifdef CONFIG_FAIR_GROUP_SCHED
> struct sched_avg avg;
> +#endif
> };
There is already a CONFIG_FAIR_GROUP_SCHED #ifdef in that structure;
does it make sense to move this variable in there instead of adding yet
another #ifdef?
next prev parent reply other threads:[~2014-02-25 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 11:47 Dietmar Eggemann
2014-02-25 13:16 ` Srikar Dronamraju
2014-02-25 17:47 ` Dietmar Eggemann
2014-02-25 19:55 ` bsegall
2014-02-25 20:52 ` Peter Zijlstra [this message]
2014-02-26 11:19 ` Dietmar Eggemann
2014-02-26 13:16 ` Peter Zijlstra
2014-02-26 17:53 ` bsegall
2014-02-27 13:32 ` [tip:sched/core] sched: Put rq' s " tip-bot for Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225205253.GB18404@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome