From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbaBZVRE (ORCPT ); Wed, 26 Feb 2014 16:17:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41116 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbaBZVRB convert rfc822-to-8bit (ORCPT ); Wed, 26 Feb 2014 16:17:01 -0500 Date: Wed, 26 Feb 2014 16:16:59 -0500 (EST) Message-Id: <20140226.161659.2024676575146527914.davem@davemloft.net> To: bjorn@mork.no Cc: freddy@asix.com.tw, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN From: David Miller In-Reply-To: <87lhwx7f19.fsf@nemi.mork.no> References: <87zjle6pif.fsf@nemi.mork.no> <20140226.154801.1466276966991949680.davem@davemloft.net> <87lhwx7f19.fsf@nemi.mork.no> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Feb 2014 13:17:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjørn Mork Date: Wed, 26 Feb 2014 22:14:10 +0100 > David Miller writes: > >> From: Bjørn Mork >> Date: Wed, 26 Feb 2014 13:13:12 +0100 >> >>> freddy@asix.com.tw writes: >>> >>>> From: Freddy Xin >>>> >>>> Add VID:DID for Lenovo OneLinkDock Gigabit LAN >>> >>> This is the same patch Keith Packard sent, but with a slighly different >>> description. I take that as another proof that we should not attempt to >>> describe devices in these drivers. Describe the driver instead. >> >> Are you saying that this patch needs to be implemented differently? > > No, sorry for being confusing. The patch is fine. But Keith sent it > first... Did I apply Keith's patch? If not, should I apply it instead?