From: Mark Brown <broonie@kernel.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: iivanov@mm-sol.com, gsi@denx.de, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] spi: core: Validate length of the transfers in message
Date: Wed, 26 Feb 2014 09:14:07 +0900 [thread overview]
Message-ID: <20140226001407.GM2927@sirena.org.uk> (raw)
In-Reply-To: <20140225.225528.453119424.anemo@mba.ocn.ne.jp>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Tue, Feb 25, 2014 at 10:55:28PM +0900, Atsushi Nemoto wrote:
> Is xfer->len == 0 invalid?
> Long time ago I have fixed atmel spi driver to support zero length
> transfer (commit 06719814 atmel_spi: support zero length transfer).
> According to Documentation/spi/spi-summary, zeto length transfer seems
> valid.
> + optionally defining short delays after transfers ... using
> the spi_transfer.delay_usecs setting (this delay can be the
> only protocol effect, if the buffer length is zero);
*sigh* I guess it is valid, though frankly I'm concerned that this
isn't a good idea - it's certainly not going to work reliably given the
need for every driver to open code this, most of them get the delay
stuff wrong.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-26 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 10:02 Ivan T. Ivanov
2014-02-22 3:01 ` Mark Brown
2014-02-25 13:55 ` Atsushi Nemoto
2014-02-26 0:14 ` Mark Brown [this message]
2014-02-27 13:38 ` Atsushi Nemoto
2014-02-28 6:19 ` Mark Brown
2014-02-28 13:55 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226001407.GM2927@sirena.org.uk \
--to=broonie@kernel.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=gsi@denx.de \
--cc=iivanov@mm-sol.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®