From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754650AbaB0DNi (ORCPT ); Wed, 26 Feb 2014 22:13:38 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.232]:4361 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751929AbaB0DNh (ORCPT ); Wed, 26 Feb 2014 22:13:37 -0500 Date: Wed, 26 Feb 2014 22:13:35 -0500 From: Steven Rostedt To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Peter Zijlstra , Frederic Weisbecker , Mathieu Desnoyers , Rusty Russell Subject: Re: [RFA][PATCH 3/4] tracing/module: Remove include of tracepoint.h from module.h Message-ID: <20140226221335.3e30572a@gandalf.local.home> In-Reply-To: <20140226190644.730153889@goodmis.org> References: <20140226190140.590029589@goodmis.org> <20140226190644.730153889@goodmis.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Feb 2014 14:01:43 -0500 Steven Rostedt wrote: > [ Request for Ack ] > > From: "Steven Rostedt (Red Hat)" > > There's nothing in the module.h header that requires tracepoint.h to be > included. Soon, tracepoint.h will require struct module, and will have to > include module.h. To avoid include hell, we need to remove the include of > tracepoint.h from module.h. > > A stable patch will require this change, so include stable in the Cc. > > Cc: stable@vger.kernel.org # 2.6.31+ Hi Rusty, This patch doesn't need to be stable, and can wait till v3.15. But I have other patches that will break with this patch (headers that needed to include tracepoint.h and not depend on a header chain to include it). Can you give me your Acked-by for this, and I'll just add it to my 3.15 queue? Thanks, -- Steve > Cc: Rusty Russell > Signed-off-by: Steven Rostedt > --- > include/linux/module.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/module.h b/include/linux/module.h > index eaf60ff..6cc28d9 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > > #include