From: Felipe Balbi <balbi@ti.com>
To: Loc Ho <lho@apm.com>
Cc: <kishon@ti.com>, <tj@kernel.org>, <olof@lixom.net>,
<arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <ddutile@redhat.com>,
<jcm@redhat.com>, <patches@apm.com>, Tuan Phan <tphan@apm.com>,
Suman Tripathi <stripathi@apm.com>
Subject: Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver
Date: Thu, 27 Feb 2014 13:02:59 -0600 [thread overview]
Message-ID: <20140227190259.GC4862@saruman.home> (raw)
In-Reply-To: <1393524848-8207-4-git-send-email-lho@apm.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Hi,
On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote:
> +/*
> + * This function is used to configure the PHY to operation as either SATA Gen1
> + * or Gen2 speed.
> + */
> +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx,
> + int lane, int gen)
why do you need to *force* the generation ? Is this because of some
silicon errata ? It almost seems like this should be done through link
negotiation between both link partners.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-02-27 19:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 18:14 [PATCH v12 0/4] PHY: Add APM X-Gene SoC 15Gbps Multi-purpose PHY support Loc Ho
2014-02-27 18:14 ` [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework Loc Ho
2014-02-27 18:14 ` [PATCH v12 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation Loc Ho
2014-02-27 18:14 ` [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver Loc Ho
2014-02-27 18:14 ` [PATCH v12 4/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries Loc Ho
2014-02-27 19:02 ` Felipe Balbi [this message]
2014-02-27 20:02 ` [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver Loc Ho
2014-02-27 19:01 ` [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework Felipe Balbi
2014-02-27 19:57 ` Loc Ho
2014-02-27 20:50 ` Felipe Balbi
2014-02-27 21:09 ` Loc Ho
2014-02-27 21:34 ` Felipe Balbi
2014-02-27 22:03 ` Loc Ho
2014-03-03 6:59 ` Loc Ho
2014-03-05 21:27 ` Loc Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227190259.GC4862@saruman.home \
--to=balbi@ti.com \
--cc=arnd@arndb.de \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=kishon@ti.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
--cc=tphan@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®