From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: James Hogan <james.hogan@imgtec.com>,
grant.likely@linaro.org, linus.walleij@linaro.org,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int
Date: Sat, 1 Mar 2014 16:01:14 +0000 [thread overview]
Message-ID: <20140301160114.GE21483@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1403011629540.18573@ionos.tec.linutronix.de>
On Sat, Mar 01, 2014 at 04:31:13PM +0100, Thomas Gleixner wrote:
> On Fri, 28 Feb 2014, James Hogan wrote:
> > On Thursday 27 February 2014 18:21:19 Jean-Jacques Hiblot wrote:
> > > drivers/irqchip/irq-metag.c | 4 ++--
> >
> > I think you've missed out drivers/irqchip/irq-metag-ext.c
>
> There is a good reason why I asked to do this with coccinelle.
Go easy, not everyone understands that complex tool - I certainly don't.
I ended up deleting it from my system after several failed attempts, and
I came to the conclusion that to use it properly, you also needed a Julia
installed along side you to learn how to write its scripts.
The big problem is it /doesn't/ do what it advertises to - I ended up
writing expression after expression to make it detect all the various
forms of what I wanted it to, which as I understand the tool is precisely
the opposite of what you're supposed to do with it.
I ended up coming to the conclusion that a well formed sed and/or grep
expression was far more useful and effective than trying to figure out
coccinelle.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-03-01 16:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 16:28 [PATCH] irq: Consider a negative return value of irq_startup() as an error Jean-Jacques Hiblot
2014-02-26 22:15 ` Thomas Gleixner
2014-02-27 16:03 ` Jean-Jacques Hiblot
2014-02-27 17:21 ` [PATCH] irq: Changed the return type of irq_chip.irq_startup() from unsigned int to int Jean-Jacques Hiblot
2014-02-28 22:52 ` James Hogan
2014-03-01 15:31 ` Thomas Gleixner
2014-03-01 16:01 ` Russell King - ARM Linux [this message]
2014-03-03 8:55 ` Jean-Jacques Hiblot
2014-03-04 10:57 ` Thomas Gleixner
2014-03-04 11:14 ` James Hogan
2014-03-03 9:22 ` [PATCH v2] " Jean-Jacques Hiblot
2014-03-07 2:49 ` [PATCH] irq: Consider a negative return value of irq_startup() as an error Linus Walleij
2014-03-08 9:15 ` Thomas Gleixner
2014-03-12 14:49 ` Linus Walleij
2014-03-12 15:10 ` Thomas Gleixner
2014-03-14 9:28 ` Linus Walleij
2014-03-12 15:06 ` [tip:irq/core] genirq: Provide irq_request/ release_resources chip callbacks tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140301160114.GE21483@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=grant.likely@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=jjhiblot@traphandler.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®