From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134AbaCDVaK (ORCPT ); Tue, 4 Mar 2014 16:30:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42332 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757072AbaCDVaG (ORCPT ); Tue, 4 Mar 2014 16:30:06 -0500 Date: Tue, 4 Mar 2014 13:30:04 -0800 From: Andrew Morton To: ebiederm@xmission.com (Eric W. Biederman) Cc: Richard Guy Briggs , Eric Paris , linux-audit@redhat.com, linux-kernel@vger.kernel.org, Subject: Re: [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough Message-Id: <20140304133004.b565820f60f595a48e621e58@linux-foundation.org> In-Reply-To: <87mwhaplo4.fsf_-_@xmission.com> References: <8738j3vzry.fsf@xmission.com> <20140301011142.GK16640@madcap2.tricolour.ca> <87fvn2r0yb.fsf@xmission.com> <874n3ir0uw.fsf_-_@xmission.com> <87mwhaplo4.fsf_-_@xmission.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Feb 2014 20:50:19 -0800 ebiederm@xmission.com (Eric W. Biederman) wrote: > > Modify audit_send_reply to directly use a non-blocking send and > to return an error on failure (if anyone cares). > > Modify audit_list_rules_send to use audit_send_reply and give up > if we can not send a packet. > > Merge audit_list_rules into iaudit_list_rules_send as the code > is now sufficiently simple to not justify to callers. > > Kill audit_send_list, audit_send_reply_thread because using > a separate thread for replies is not needed when sending > packets syncrhonously. Nothing much seems to be happening here? In an earlier email you said "While reading through 3.14-rc1 I found a pretty siginficant mishandling of network namespaces in the recent audit changes." Were those recent audit changes a post-3.14 thing? And what is the user-visible effect of the mishandling? Thanks.