mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Mackerras <paulus@samba.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Seiji Aguchi <seiji.aguchi@hds.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Closing on the CR2 leak bug
Date: Tue, 4 Mar 2014 18:41:12 -0500	[thread overview]
Message-ID: <20140304184112.0a3fe811@gandalf.local.home> (raw)
In-Reply-To: <531654D8.5040409@zytor.com>

On Tue, 04 Mar 2014 14:34:00 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> So we need to get something into x86/urgent for the CR2 bug.
> 
> It seems like a no-brainer to do the hoisting patch, for which I prefer
> the version proposed by Jiri Olsa which reads %cr2 and then passes it to
> __do_page_fault() in a GPR:
> 
> http://lkml.kernel.org/r/20140228160526.GD1133@krava.brq.redhat.com
> 
> As fart as I can tell this should fix Vince's problem as well.
> 
> Anyone who objects to this?  Otherwise I will put it in tip:x86/urgent
> tomorrow.
> 
> Do we need any more refinements this late in the -rc cycle?
> 

The only other issue is if perf traces from function context and traces
the trace_do_page_fault() call. But other than that, sure, take Jiri's
patch.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

Please also add the reported/tested-by from Vince Weaver and add a
Link: to the other thread, as it got pretty detailed there too.


 -- Steve

  reply	other threads:[~2014-03-04 23:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 22:34 H. Peter Anvin
2014-03-04 23:41 ` Steven Rostedt [this message]
2014-03-04 23:44   ` H. Peter Anvin
2014-03-05  0:00     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304184112.0a3fe811@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@ghostprotocols.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=seiji.aguchi@hds.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®