From: Alessandro Zummo <a.zummo@towertech.it>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Cc: David Dajun Chen <david.chen@diasemi.com>,
LKML <linux-kernel@vger.kernel.org>,
RTC linux <rtc-linux@googlegroups.com>
Subject: Re: [RFC V1 2/2] rtc: da9063: RTC driver
Date: Wed, 5 Mar 2014 16:41:02 +0100 [thread overview]
Message-ID: <20140305164102.1f8644e4@linux.lan.towertech.it> (raw)
In-Reply-To: <649fad1df15ee9f79655bc109282a21e9e9810cf.1394022316.git.stwiss.opensource@diasemi.com>
On Wed, 5 Mar 2014 12:25:16 +0000
"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> wrote:
> + if (IS_ERR(rtc->rtc_dev)) {
> + ret = PTR_ERR(rtc->rtc_dev);
> + goto err;
> + }
please,
return PTR_ERR(....)
> +
> + irq_alarm = platform_get_irq_byname(pdev, "ALARM");
> + ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL,
> + da9063_alarm_event,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + "ALARM", rtc);
> + if (ret)
> + dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
> + irq_alarm, ret);
> +
> + da9063_data_to_tm(data, &rtc->alarm_time);
> + rtc->rtc_sync = false;
> +err:
> + return ret;
> +}
if the interrupt is mandatory you should request it before registering
the rtc device. if it isn't, please return 0.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2014-03-05 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 12:25 [RFC V1 0/2] da9063: Support for RTC and register definition updates Opensource [Steve Twiss]
2014-03-05 12:25 ` [RFC V1 1/2] mfd: da9063: Upgrade of register definitions to support production silicon Opensource [Steve Twiss]
2014-03-05 12:25 ` [RFC V1 2/2] rtc: da9063: RTC driver Opensource [Steve Twiss]
2014-03-05 15:41 ` Alessandro Zummo [this message]
2014-03-05 16:20 ` Opensource [Steve Twiss]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305164102.1f8644e4@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=david.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome