From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752969AbaCFTe5 (ORCPT ); Thu, 6 Mar 2014 14:34:57 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60210 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbaCFTe4 (ORCPT ); Thu, 6 Mar 2014 14:34:56 -0500 Date: Thu, 06 Mar 2014 14:34:54 -0500 (EST) Message-Id: <20140306.143454.1047620719955721469.davem@davemloft.net> To: kys@microsoft.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH 6/6] Drivers: net: hyperv: Enable large send offload From: David Miller In-Reply-To: <1394104390-23477-6-git-send-email-kys@microsoft.com> References: <1394104358-23438-1-git-send-email-kys@microsoft.com> <1394104390-23477-1-git-send-email-kys@microsoft.com> <1394104390-23477-6-git-send-email-kys@microsoft.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Mar 2014 11:34:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:10 -0800 > + ppi = init_ppi_data(rndis_msg, NDIS_LSO_PPI_SIZE, > + TCP_LARGESEND_PKTINFO); This is not indented properly, "TCP_LARGESEND_PKTINFO);" should start at the first column after the openning parenthesis of "init_ppi_data(". > + ~csum_tcpudp_magic(ip_hdr(skb)->saddr, > + ip_hdr(skb)->daddr, 0, IPPROTO_TCP, 0); Likewise.