mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Maxin B. John" <maxin.john@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	andreas.dilger@intel.com, bergwolf@gmail.com,
	alexey.zhuravlev@intel.com, josh@joshtriplett.org,
	dulshani.gunawardhana89@gmail.com, jinshan.xiong@intel.com,
	"Maxin B. John" <maxin.john@enea.com>
Subject: Re: [PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference
Date: Thu, 6 Mar 2014 11:53:56 -0800	[thread overview]
Message-ID: <20140306195356.GB3403@kroah.com> (raw)
In-Reply-To: <1394024676-35160-2-git-send-email-maxin.john@enea.com>

On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote:
> From: "Maxin B. John" <maxin.john@enea.com>
> 
> osc_obd can be NULL. cppcheck reported this:
> [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference:
> osc_obd - otherwise it is redundant to check if osc_obd is null at line 295

Same problem, osc_obd can never be NULL, please be more careful with
your patches, and just remove pointless tests instead of papering over
them with patches like this.

thanks.

greg k-h

  reply	other threads:[~2014-03-06 19:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 13:04 [PATCH 1/2] lustre/mdc_lib: " Maxin B. John
2014-03-05 13:04 ` [PATCH 2/2] lustre/lov_obd: " Maxin B. John
2014-03-06 19:53   ` Greg KH [this message]
2014-03-05 18:53 ` [PATCH 1/2] lustre/mdc_lib: " Dan Carpenter
2014-03-06 19:51   ` Greg KH
2014-03-06 21:41     ` Maxin B. John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140306195356.GB3403@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexey.zhuravlev@intel.com \
    --cc=andreas.dilger@intel.com \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dulshani.gunawardhana89@gmail.com \
    --cc=jinshan.xiong@intel.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxin.john@enea.com \
    --cc=maxin.john@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®