From: Jenny Tc <jenny.tc@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"Anton Vorontsov" <cbouatmailru@gmail.com>,
"Anton Vorontsov" <anton.vorontsov@linaro.org>,
"Kim Milo" <Milo.Kim@ti.com>, "Lee Jones" <lee.jones@linaro.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sachin Kamat" <sachin.kamat@linaro.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rhyland Klein" <rklein@nvidia.com>,
"Pavel Machek" <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"David Woodhouse" <dwmw2@infradead.org>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Sebastian Reichel" <sre@ring0.de>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pallala Ramakrishna" <ramakrishna.pallala@intel.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver
Date: Fri, 7 Mar 2014 09:19:04 +0530 [thread overview]
Message-ID: <20140307034904.GB19526@jenny-desktop> (raw)
In-Reply-To: <CACRpkdbuCC=-aYmyeaGW0GfkhRU8SEc=1+2f6k3tA7TygiZRJA@mail.gmail.com>
On Fri, Mar 07, 2014 at 11:03:02AM +0800, Linus Walleij wrote:
> On Fri, Feb 28, 2014 at 12:27 PM, Jenny Tc <jenny.tc@intel.com> wrote:
> > On Thu, Feb 27, 2014 at 09:08:01PM +0100, Linus Walleij wrote:
> >> On Thu, Feb 20, 2014 at 6:53 AM, Jenny TC <jenny.tc@intel.com> wrote:
> >>
> >> > +++ b/include/linux/power/power_supply_charger.h
> >>
> >> > +#define MAX_CUR_VOLT_SAMPLES 3
> >> > +#define DEF_CUR_VOLT_SAMPLE_JIFF (30*HZ)
> >>
> >> Why are things defined in Jiffies like this insead of seconds, milliseconds
> >> etc? This will vary with the current operating frequency of the system,
> >> why should physical measurements do that?
> >
> > Is it fine if I use msecs_to_jiffies(30000)?
>
> Keep the
> #define DEF_CUR_VOLT_SAMPLE_PERIOD 30000
>
> Then use msecs_to_jiffies(DEF_CUR_VOLT_SAMPLE_PERIOD)
> in the call site.
>
Ok..fine will fix it in next patch set
> >> > +enum psy_charger_cable_event {
> >> > + PSY_CHARGER_CABLE_EVENT_DISCONNECT = 0,
> >> > + PSY_CHARGER_CABLE_EVENT_CONNECT,
> >> > + PSY_CHARGER_CABLE_EVENT_UPDATE,
> >> > + PSY_CHARGER_CABLE_EVENT_RESUME,
> >> > + PSY_CHARGER_CABLE_EVENT_SUSPEND,
> >> > +};
> >> > +
> >> > +enum psy_charger_cable_type {
> >> > + PSY_CHARGER_CABLE_TYPE_NONE = 0,
> >> > + PSY_CHARGER_CABLE_TYPE_USB_SDP = 1 << 0,
> >> > + PSY_CHARGER_CABLE_TYPE_USB_DCP = 1 << 1,
> >> > + PSY_CHARGER_CABLE_TYPE_USB_CDP = 1 << 2,
> >> > + PSY_CHARGER_CABLE_TYPE_USB_ACA = 1 << 3,
> >> > + PSY_CHARGER_CABLE_TYPE_AC = 1 << 4,
> >> > + PSY_CHARGER_CABLE_TYPE_ACA_DOCK = 1 << 5,
> >> > + PSY_CHARGER_CABLE_TYPE_ACA_A = 1 << 6,
> >> > + PSY_CHARGER_CABLE_TYPE_ACA_B = 1 << 7,
> >> > + PSY_CHARGER_CABLE_TYPE_ACA_C = 1 << 8,
> >> > + PSY_CHARGER_CABLE_TYPE_SE1 = 1 << 9,
> >> > + PSY_CHARGER_CABLE_TYPE_MHL = 1 << 10,
> >> > + PSY_CHARGER_CABLE_TYPE_B_DEVICE = 1 << 11,
> >> > +};
> >>
> >> Why is this even an enum? It is clearly bitfields. I would just:
> >>
> >> #include <linux/bitops.h>
> >>
> >> #define PSY_CHARGER_CABLE_TYPE_NONE 0x0
> >> #define PSY_CHARGER_CABLE_TYPE_USB_SDP BIT(0)
> >> #define PSY_CHARGER_CABLE_TYPE_USB_DCP BIT(1)
> >> (etc)
> >
> > This is to ensure type checks when the cable types are handled, #defines will
> > not help in type checks.
>
> Type checks with static code check tools? But misrepresenting
> a bitfield as an enum just to satisfy a static code checker is not
> OK IMO.
not just for tools, compile time type checks also.
next prev parent reply other threads:[~2014-03-07 3:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 5:53 [PATCH v6 0/4] power_supply: Introduce power supply " Jenny TC
2014-02-20 5:53 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-20 5:53 ` [PATCH 2/4] power_supply: Introduce generic psy charging driver Jenny TC
2014-02-27 20:08 ` Linus Walleij
2014-02-28 4:27 ` Jenny Tc
2014-03-07 3:03 ` Linus Walleij
2014-03-07 3:49 ` Jenny Tc [this message]
2014-03-07 20:09 ` Pavel Machek
2014-02-28 10:01 ` Pavel Machek
2014-03-07 3:04 ` Linus Walleij
2014-03-07 20:10 ` Pavel Machek
2014-03-12 14:37 ` Linus Walleij
2014-03-13 9:12 ` Pavel Machek
2014-03-14 10:36 ` Linus Walleij
2014-03-14 19:25 ` Mark Brown
2014-02-20 5:53 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-02-20 5:54 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 6:04 [PATCHv11 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-07-08 6:04 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-07-14 13:34 ` Pavel Machek
2014-07-18 2:18 ` Sebastian Reichel
2014-07-18 3:38 ` Tc, Jenny
2014-07-18 7:52 ` Pavel Machek
2014-06-30 9:55 [PATCHv10 0/4] power_supply: Introduce power supply " Jenny TC
2014-06-30 9:55 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-06-19 14:02 [PATCHv9 0/4] power_supply: Introduce power supply " Jenny TC
2014-06-19 14:02 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-02-04 5:12 [PATCH v5 0/4] power_supply: Introduce power supply " Jenny TC
2014-02-04 5:12 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-05 8:14 ` Jenny Tc
2014-02-12 11:00 ` Pavel Machek
2014-02-13 0:51 ` Jingoo Han
2014-01-30 17:30 [PATCH v4 0/4] power_supply: Introduce power supply " Jenny TC
2014-01-30 17:30 ` [PATCH 2/4] power_supply: Introduce generic psy " Jenny TC
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307034904.GB19526@jenny-desktop \
--to=jenny.tc@intel.com \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=ramakrishna.pallala@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®