mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, zhuzhenhua@allwinnertech.com,
	linux-sunxi@googlegroups.com, kevin.z.m.zh@gmail.com,
	sunny@allwinnertech.com, shuge@allwinnertech.com,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call
Date: Fri, 7 Mar 2014 09:52:23 +0000	[thread overview]
Message-ID: <20140307095222.GG21483@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1393950521-4173-2-git-send-email-maxime.ripard@free-electrons.com>

On Tue, Mar 04, 2014 at 05:28:37PM +0100, Maxime Ripard wrote:
> The Allwinner A31 SoC using that IP has a reset controller maintaining
> it reset unless told otherwise.
> 
> Add some optional reset support to the driver.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

This appears to be causing some build errors in Olof's next builder
for many of the ARM platforms which make use of this:

drivers/i2c/busses/i2c-mv64xxx.c:924: undefined reference to `reset_control_assert'
drivers/i2c/busses/i2c-mv64xxx.c:904: undefined reference to `reset_control_assert'
drivers/i2c/busses/i2c-mv64xxx.c:771: undefined reference to `devm_reset_control_get'
drivers/i2c/busses/i2c-mv64xxx.c:778: undefined reference to `reset_control_deassert'

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

  parent reply	other threads:[~2014-03-07  9:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 16:28 [PATCH v3 0/5] ARM: sun6i: Add support for the A31 I2C controller Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-05 16:31   ` Wolfram Sang
2014-03-07  9:52   ` Russell King - ARM Linux [this message]
2014-03-07 10:07     ` Maxime Ripard
2014-03-07 10:34       ` Russell King - ARM Linux
2014-03-07 10:37         ` Wolfram Sang
2014-03-07 11:11         ` [linux-sunxi] " Chen-Yu Tsai
2014-03-07 11:18           ` Wolfram Sang
2014-03-07 13:43             ` [PATCH] i2c: mv64xxx: Fix circular dependencies warning and compilation breakage Maxime Ripard
2014-03-07 14:24               ` Wolfram Sang
2014-03-07 14:26                 ` Wolfram Sang
2014-03-07 14:48                 ` Maxime Ripard
2014-03-07 13:44             ` [linux-sunxi] Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver Maxime Ripard
2014-03-05 16:34   ` Wolfram Sang
2014-03-07 10:13     ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 3/5] ARM: sun6i: Enable the I2C controllers Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 4/5] ARM: sun6i: Enable the I2C muxing options Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 5/5] ARM: sun6i: colombus: Enable the I2C controllers Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307095222.GG21483@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=kevin.z.m.zh@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=shuge@allwinnertech.com \
    --cc=sunny@allwinnertech.com \
    --cc=wsa@the-dreams.de \
    --cc=zhuzhenhua@allwinnertech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®