From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbaCHFeZ (ORCPT ); Sat, 8 Mar 2014 00:34:25 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:41085 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbaCHFaZ (ORCPT ); Sat, 8 Mar 2014 00:30:25 -0500 From: Grant Likely Subject: Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of To: Mauro Carvalho Chehab , Russell King - ARM Linux Cc: Philipp Zabel , Tomi Valkeinen , Guennadi Liakhovetski , Rob Herring , Sylwester Nawrocki , Laurent Pinchart , Kyungmin Park , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org In-Reply-To: <20140306121721.6186dafb@samsung.com> References: <1394011242-16783-1-git-send-email-p.zabel@pengutronix.de> < 53170C00.20200@ti.com> <1394030554.8754.31.camel@paszta.hi.pengutronix.de> <20140306141657.GB21483@n2100.arm.linux.org.uk> <20140306121721.6186dafb@ samsung.com> Date: Fri, 07 Mar 2014 18:41:38 +0000 Message-Id: <20140307184138.7FF68C40CC5@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Mar 2014 12:17:21 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 06 Mar 2014 14:16:57 +0000 > Russell King - ARM Linux escreveu: > > > On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: > > > Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: > > > > Hi, > > > > > > > > On 05/03/14 11:20, Philipp Zabel wrote: > > > > > Hi, > > > > > > > > > > this version of the OF graph helper move series further addresses a few of > > > > > Tomi's and Sylwester's comments. > > > > > > > > > > Changes since v5: > > > > > - Fixed spelling errors and a wrong device node name in the link section > > > > > - Added parentless previous endpoint's full name to warning > > > > > - Fixed documentation comment for of_graph_parse_endpoint > > > > > - Unrolled for-loop in of_graph_get_remote_port_parent > > > > > > > > > > Philipp Zabel (8): > > > > > [media] of: move graph helpers from drivers/media/v4l2-core to > > > > > drivers/of > > > > > Documentation: of: Document graph bindings > > > > > of: Warn if of_graph_get_next_endpoint is called with the root node > > > > > of: Reduce indentation in of_graph_get_next_endpoint > > > > > [media] of: move common endpoint parsing to drivers/of > > > > > of: Implement simplified graph binding for single port devices > > > > > of: Document simplified graph binding for single port devices > > > > > of: Warn if of_graph_parse_endpoint is called with the root node > > > > > > > > So, as I've pointed out, I don't agree with the API, as it's too limited > > > > and I can't use it, but as this series is (mostly) about moving the > > > > current API to a common place, it's fine for me. > > > > > > > > Acked-by: Tomi Valkeinen > > > > > > Thanks. I'll be happy to help expanding the API to parse ports > > > individually, once this gets accepted. > > > > > > Mauro, Guennadi, are you fine with how this turned out? I'd like to get > > > your acks again, for the changed location. > > From my side, there's nothing on such code that is V4L2 specific. > Moving it to drivers/of makes sense on my eyes. > > Acked-by: Mauro Carvalho Chehab > > > > I'll need those acks before I can even think about queuing up the > > imx-drm bits. > > > > Another way to deal with this is if this gets pulled into the V4L tree > > from Philipp's git tree, I can also pull that in myself. What mustn't > > happen is for these to be committed independently as patches. > > If everyone agrees, I actually prefer have this patch applied on my tree, > in order to avoid some potential merge conflicts at the merge window, > as we might have other drivers and changes there touching on those API > calls (I'm aware of a series of patches from Sylwester with some DT > stuff on it. Not sure if it would be affected by such changes or not). No. I disagree. Aside from the api changes this is primarily a drivers/of series. I should go via me or Rob Herring. If you're concerned about resolving conflicts then I can put it into a separate branch that you can merge into your tree also. g.