From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, namhyung@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/8] perf, tools: Support handling complete branch stacks as histograms v4
Date: Fri, 7 Mar 2014 16:54:08 -0300 [thread overview]
Message-ID: <20140307195408.GB6519@infradead.org> (raw)
In-Reply-To: <20140307195100.GA6519@infradead.org>
Em Fri, Mar 07, 2014 at 04:51:00PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Mar 07, 2014 at 02:19:49PM +0100, Jiri Olsa escreveu:
> > On Thu, Feb 27, 2014 at 08:22:26PM -0800, Andi Kleen wrote:
> > > +static void resolve_branch_ams(struct machine *machine, struct thread *thread,
> > > + u64 ip,
> > > + struct addr_location *al)
> > the function name is confusing.. there's no branch or ams
> > being dealt with in here
> yeah, it should be renamed, and all it does is to try to find something
> in all the possible cpu modes, so I think we should rename this to:
> thread__find_cpumode_addr_location()
> And move it to right after thread__find_addr_location(), then use it
> here, doing that and combining the other patches, etc, should have it in
> a place for testing soon.
>
> > maybe something like resolve_ip_al or resolve_ip ?
Humm, then it gets overly long and we have
PERF_RECORD_MISC_CPUMODE_UNKNOWN, so I'll try making it so that if
cpumode is passed as PERF_RECORD_MISC_CPUMODE_UNKNOWN,
thread__find_addr_location() will try to figure it out.
- Arnaldo
next prev parent reply other threads:[~2014-03-07 19:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 4:22 perf: Implement lbr-as-callgraph v4 Andi Kleen
2014-02-28 4:22 ` [PATCH 1/8] perf, tools: fix BFD detection on opensuse Andi Kleen
2014-02-28 4:22 ` [PATCH 2/8] perf, tools: Support handling complete branch stacks as histograms v4 Andi Kleen
2014-03-05 10:29 ` Jiri Olsa
2014-03-05 15:31 ` Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
2014-03-07 13:19 ` Jiri Olsa
2014-03-07 19:51 ` Arnaldo Carvalho de Melo
2014-03-07 19:54 ` Arnaldo Carvalho de Melo [this message]
2014-03-11 0:43 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 3/8] perf, tools: Add --branch-history option to report v2 Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
2014-03-11 0:31 ` Andi Kleen
2014-03-11 15:25 ` Jiri Olsa
2014-03-11 20:21 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 4/8] perf, tools: Enable printing the srcline in the history v2 Andi Kleen
2014-03-01 16:22 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 5/8] perf, tools: Only print base source file for srcline Andi Kleen
2014-02-28 4:22 ` [PATCH 6/8] perf, tools: Support source line numbers in annotate Andi Kleen
2014-02-28 4:22 ` [PATCH 7/8] perf, tools: Fix srcline sort key output to use width Andi Kleen
2014-02-28 4:22 ` [PATCH 8/8] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307195408.GB6519@infradead.org \
--to=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®