From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Grant Likely <grant.likely@linaro.org>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
gregory.clement@free-electrons.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt: platform driver: Fill the resources before probe and defer if needed
Date: Sat, 8 Mar 2014 11:59:48 +0000 [thread overview]
Message-ID: <20140308115948.GX21483@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140308073758.DA63FC408EC@trevor.secretlab.ca>
On Sat, Mar 08, 2014 at 07:37:58AM +0000, Grant Likely wrote:
> I believe we already talked about the above test. This function must
> only process devices created by of_platform_populate(). Merely checking
> the of_node pointer is not a sufficient test because there are other
> paths in the kernel for creating platform_devices that might get a node
> pointer attached to it.
There definitely are: there are a number of platform device drivers
which create a new platform device structure, and copy the of_node
pointer across.
However, that's really sick code, and can result in the platform device
driver probing the device it just created... this practise should be
outlawed.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-03-08 12:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:57 [PATCH] " Jean-Jacques Hiblot
2014-02-13 10:06 ` Jean-Jacques Hiblot
2014-02-18 20:22 ` Greg KH
2014-02-18 22:34 ` Grant Likely
2014-02-20 15:30 ` Grant Likely
[not found] ` < 1392988720-20976-1-git-send-email-jjhiblot@traphandler.com>
[not found] ` < 902E09E6452B0E43903E4F2D568737AB0B9D2959@DFRE01.ent.ti.com>
[not found] ` < CACh+v5MPTx6nwVj1s3krntJqQ6DMTQ2hQ93Hc+rRNAuFa9+qPw@mail.gmail.com>
[not found] ` <20140308073758 .DA63FC408EC@trevor.secretlab.ca>
[not found] ` < CACh+v5P=tcc-h_9r7Btwyu+jWjwH2ocmW4VCgDYqY7VMWsHuOA@mail.gmail.com>
[not found] ` < 20140317142443.A2447C40A85@trevor.secretlab.ca>
2014-02-21 13:18 ` [PATCH v2] " Jean-Jacques Hiblot
2014-02-21 15:37 ` Strashko, Grygorii
2014-02-21 16:22 ` Jean-Jacques Hiblot
2014-02-27 16:43 ` Jean-Jacques Hiblot
2014-03-08 7:32 ` Grant Likely
2014-02-27 15:01 ` Ludovic Desroches
2014-03-08 7:37 ` Grant Likely
2014-03-08 11:59 ` Russell King - ARM Linux [this message]
2014-03-17 11:07 ` Jean-Jacques Hiblot
2014-03-17 14:24 ` Grant Likely
2014-03-17 15:20 ` Jean-Jacques Hiblot
2014-03-20 16:11 ` Grant Likely
2014-03-21 14:46 ` [PATCH v3 0/2] " Jean-Jacques Hiblot
2014-03-21 14:46 ` [PATCH v3 1/2] of: irq: Added of_find_irq_domain() to get the domain of an irq Jean-Jacques Hiblot
2014-03-21 14:46 ` [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed Jean-Jacques Hiblot
2014-04-11 17:28 ` Rob Herring
2014-04-18 20:52 ` Tony Lindgren
2014-04-18 21:39 ` Rob Herring
2014-04-18 21:58 ` Tony Lindgren
2014-04-18 23:03 ` Russell King - ARM Linux
2014-04-18 23:24 ` Tony Lindgren
2014-04-21 13:47 ` Rob Herring
2014-04-21 15:54 ` Tony Lindgren
2014-04-21 19:01 ` Rob Herring
2014-04-21 20:25 ` Tony Lindgren
2014-04-22 3:05 ` Tony Lindgren
2014-04-22 4:57 ` Tony Lindgren
2014-04-23 22:03 ` Rob Herring
2014-04-23 17:38 ` Russell King - ARM Linux
2014-04-23 15:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140308115948.GX21483@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@free-electrons.com \
--cc=jjhiblot@traphandler.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®