From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: "Håvard Skinnemoen" <hskinnemoen@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/avr32/mm/cache.c: export symbol flush_icache_range() for module using
Date: Sat, 8 Mar 2014 23:17:22 +0100 [thread overview]
Message-ID: <20140308221721.GA30934@samfundet.no> (raw)
In-Reply-To: <531B8FD8.6040704@gmail.com>
Around Sun 09 Mar 2014 05:47:04 +0800 or thereabout, Chen Gang wrote:
>
> After this patch, our linux kernel can pass "avr32-linux-" allmodconfig
> (it contents quite a few of warnings, but after check, I guess they are
> not kernel's issue).
That sounds great, I am a bit surprised however that the lkdtm module need
flush_icache_range. Would have been interesting to look into what causes this
dependency.
I will pull this into my for-linus branch, and push during the next merge
window.
> On 03/09/2014 05:35 AM, Chen Gang wrote:
>> Need export symbol flush_icache_range() to modules, just like another
>> platforms have done, or can not pass compiling.
>>
>> The related error (with allmodconfig under avr32):
>>
>> ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>> ---
>> arch/avr32/mm/cache.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/avr32/mm/cache.c b/arch/avr32/mm/cache.c
>> index 6a46ecd..85d635c 100644
>> --- a/arch/avr32/mm/cache.c
>> +++ b/arch/avr32/mm/cache.c
>> @@ -111,6 +111,7 @@ void flush_icache_range(unsigned long start, unsigned long end)
>> __flush_icache_range(start & ~(linesz - 1),
>> (end + linesz - 1) & ~(linesz - 1));
>> }
>> +EXPORT_SYMBOL(flush_icache_range);
>>
>> /*
>> * This one is called from __do_fault() and do_swap_page().
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2014-03-08 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 21:35 Chen Gang
2014-03-08 21:47 ` Chen Gang
2014-03-08 22:17 ` Hans-Christian Egtvedt [this message]
2014-03-09 15:19 ` Chen Gang
2014-03-15 21:18 ` Chen Gang
2014-03-22 23:12 ` Chen Gang
2014-03-25 8:48 ` Hans-Christian Egtvedt
2014-03-25 8:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140308221721.GA30934@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=gang.chen.5i5j@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome