From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johannes Thumshirn <johannes.thumshirn@men.de>
Cc: linux-kernel@vger.kernel.org, Johannes Thumshirn <morbidrsa@gmail.com>
Subject: Re: [PATCH 1/2] drivers: mcb: Fix build error discovered by 0-day bot
Date: Sat, 8 Mar 2014 21:57:06 -0800 [thread overview]
Message-ID: <20140309055706.GA26187@kroah.com> (raw)
In-Reply-To: <1393879609-3284-1-git-send-email-johannes.thumshirn@men.de>
On Mon, Mar 03, 2014 at 09:46:48PM +0100, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <morbidrsa@gmail.com>
>
> Make mcb depend on HAS_IOMEM and mcb-pci depend on PCI. This fixes build errors
> discovered by the 0-day kernel build testing system.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
> drivers/mcb/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mcb/Kconfig b/drivers/mcb/Kconfig
> index b8f5d46..87d5a46 100644
> --- a/drivers/mcb/Kconfig
> +++ b/drivers/mcb/Kconfig
> @@ -4,7 +4,7 @@
>
> menuconfig MCB
> tristate "MCB support"
> - default m
> + depends on HAS_IOMEM
> help
>
> The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
> @@ -18,6 +18,7 @@ if MCB
> config MCB_PCI
> tristate "PCI based MCB carrier"
> default m
This should not be default m either, please redo this against my latest
tree and resend.
thanks,
greg k-h
prev parent reply other threads:[~2014-03-09 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 20:46 Johannes Thumshirn
2014-03-03 20:46 ` [PATCH 2/2] iio: adc: Fix build error discovered by 0-day build bot Johannes Thumshirn
2014-03-09 5:52 ` Greg Kroah-Hartman
2014-03-09 5:53 ` Greg Kroah-Hartman
2014-03-09 5:57 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309055706.GA26187@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johannes.thumshirn@men.de \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome