From: David Miller <davem@davemloft.net>
To: peter.bostrom@netrounds.com
Cc: kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vlan: Set correct source MAC address with TX VLAN offload enabled
Date: Mon, 10 Mar 2014 22:22:26 -0400 (EDT) [thread overview]
Message-ID: <20140310.222226.1557956325482157663.davem@davemloft.net> (raw)
In-Reply-To: <1394464635.27812.7.camel@peter-laptop>
From: Peter Boström <peter.bostrom@netrounds.com>
Date: Mon, 10 Mar 2014 16:17:15 +0100
> With TX VLAN offload enabled the source MAC address for frames sent using the
> VLAN interface is currently set to the address of the real interface. This is
> wrong since the VLAN interface may be configured with a different address.
>
> The bug was introduced in commit 2205369a314e12fcec4781cc73ac9c08fc2b47de
> ("vlan: Fix header ops passthru when doing TX VLAN offload.").
>
> This patch sets the source address before calling the create function of the
> real interface.
>
> Signed-off-by: Peter Boström <peter.bostrom@netrounds.com>
Good catch.
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2014-03-11 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 15:17 Peter Boström
2014-03-11 2:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310.222226.1557956325482157663.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.bostrom@netrounds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®