From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754548AbaCJUC3 (ORCPT ); Mon, 10 Mar 2014 16:02:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40585 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754392AbaCJUC0 (ORCPT ); Mon, 10 Mar 2014 16:02:26 -0400 Date: Mon, 10 Mar 2014 13:02:24 -0700 From: Andrew Morton To: Kees Cook Cc: Rusty Russell , Linus Torvalds , Andrew Honig , Michal Marek , "x86@kernel.org" , Tejun Heo , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, LKML Subject: Re: [PATCH v2 0/2] kallsyms: handle special absolute symbols Message-Id: <20140310130224.70ec6a1940ec636bfb89f6bb@linux-foundation.org> In-Reply-To: References: <1394240425-11647-1-git-send-email-keescook@chromium.org> <20140310120657.80aa5569714e5b53c6662798@linux-foundation.org> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Mar 2014 12:58:06 -0700 Kees Cook wrote: > On Mon, Mar 10, 2014 at 12:06 PM, Andrew Morton > wrote: > > On Fri, 7 Mar 2014 17:00:23 -0800 Kees Cook wrote: > >> Handles 0-based per_cpu variables as being absolute so they are > >> not relocated under kASLR on x86_64. > > > > Would it be prudent to revert 0f55159d091cb1e5 ("kallsyms: fix absolute > > addresses for kASLR") then sort all this out for 3.15? > > My opinion is that if it breaks a real-life case (avr32), it should be > reverted. We aren't going to be able to test this on 40 architectures so yes, let's take the cautious approach. > The only people affected by the kallsyms per_cpu relocation > reporting bug are those using kASLR on x86, and even then the bug is a > corner case on live kernel debugging. > > I am fine either way.