mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Valentina Manea <valentina.manea.m@gmail.com>
Cc: tulinizer@gmail.com, stern@rowland.harvard.edu,
	mail@beyermatthias.de, hdegoede@redhat.com, f.manzan@gmail.com,
	kurt@garloff.de, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, firefly@lists.rosedu.org,
	andy.grover@gmail.com
Subject: Re: [PATCH 1/2] usbcore: rename struct dev_state to struct usb_dev_state
Date: Mon, 10 Mar 2014 09:51:50 -0700	[thread overview]
Message-ID: <20140310165150.GB12687@kroah.com> (raw)
In-Reply-To: <1394440601-13573-2-git-send-email-valentina.manea.m@gmail.com>

On Mon, Mar 10, 2014 at 10:36:40AM +0200, Valentina Manea wrote:
> Since it is needed outside usbcore and exposed in include/linux/usb.h,
> it conflicts with enum dev_state in rt2x00 wireless driver.
> 
> Mark it as usb specific to avoid conflicts in the future.
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

With this patch, you break the usbip code, you can never have a patch
that breaks the build :(

I'll merge both of these together to prevent this from happening.

thanks,

greg k-h

  reply	other threads:[~2014-03-10 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  8:36 [PATCH 0/2] Rename " Valentina Manea
2014-03-10  8:36 ` [PATCH 1/2] usbcore: rename " Valentina Manea
2014-03-10 16:51   ` Greg KH [this message]
2014-03-10  8:36 ` [PATCH 2/2] staging: usbip: rename struct dev_state to usb_dev_state Valentina Manea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140310165150.GB12687@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andy.grover@gmail.com \
    --cc=f.manzan@gmail.com \
    --cc=firefly@lists.rosedu.org \
    --cc=hdegoede@redhat.com \
    --cc=kurt@garloff.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@beyermatthias.de \
    --cc=stern@rowland.harvard.edu \
    --cc=tulinizer@gmail.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®