From: David Miller <davem@davemloft.net>
To: linus.luessing@web.de
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
stephen@networkplumber.org, linux-kernel@vger.kernel.org,
jstancek@redhat.com, fwestpha@redhat.com
Subject: Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only
Date: Tue, 11 Mar 2014 23:23:31 -0400 (EDT) [thread overview]
Message-ID: <20140311.232331.953854418721439734.davem@davemloft.net> (raw)
In-Reply-To: <1394486725-4992-2-git-send-email-linus.luessing@web.de>
From: Linus Lüssing <linus.luessing@web.de>
Date: Mon, 10 Mar 2014 22:25:25 +0100
> Without this check someone could easily create a denial of service
> by injecting multicast-specific queries to enable the bridge
> snooping part if no real querier issuing periodic general queries
> is present on the link which would result in the bridge wrongly
> shutting down ports for multicast traffic as the bridge did not learn
> about these listeners.
>
> With this patch the snooping code is enabled upon receiving valid,
> general queries only.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Applied.
next prev parent reply other threads:[~2014-03-12 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 21:25 [PATCHv2 1/2] bridge: multicast: add sanity check for general query destination Linus Lüssing
2014-03-10 21:25 ` [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only Linus Lüssing
2014-03-10 22:56 ` Hannes Frederic Sowa
2014-03-11 1:48 ` Linus Lüssing
2014-03-12 3:23 ` David Miller [this message]
2014-03-12 3:23 ` [PATCHv2 1/2] bridge: multicast: add sanity check for general query destination David Miller
2014-03-12 18:34 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311.232331.953854418721439734.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=fwestpha@redhat.com \
--cc=jstancek@redhat.com \
--cc=linus.luessing@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®