From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-spi@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm
Date: Tue, 11 Mar 2014 10:47:13 +0000 [thread overview]
Message-ID: <20140311104713.GN28112@sirena.org.uk> (raw)
In-Reply-To: <1394531952-3905-3-git-send-email-geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Tue, Mar 11, 2014 at 10:59:12AM +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Applied, thanks, though...
> - ret = clk_prepare_enable(rspi->clk);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "unable to prepare/enable clock\n");
> - goto error1;
> - }
> + pm_runtime_enable(&pdev->dev);
...due to the runtime PM API being configurable you're supposed to start
off with the device runtime enabled (this applies to some of the other
patches too). I'm not sure that's terribly realistic for these drivers
though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-11 10:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 9:59 [PATCH 1/3] spi: sh-hspi: Add missing call to pm_runtime_disable() in failure path Geert Uytterhoeven
2014-03-11 9:59 ` [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework Geert Uytterhoeven
2014-03-11 10:45 ` Mark Brown
2014-03-11 15:55 ` Laurent Pinchart
2014-03-11 16:23 ` Geert Uytterhoeven
2014-03-11 16:32 ` Laurent Pinchart
2014-03-11 17:44 ` Geert Uytterhoeven
2014-03-11 17:57 ` Laurent Pinchart
2014-03-12 1:23 ` Magnus Damm
2014-03-12 11:26 ` Laurent Pinchart
2014-03-12 11:28 ` Magnus Damm
2014-03-11 9:59 ` [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm Geert Uytterhoeven
2014-03-11 10:47 ` Mark Brown [this message]
2014-03-11 13:10 ` Geert Uytterhoeven
2014-03-11 13:26 ` Mark Brown
2014-03-11 13:35 ` Geert Uytterhoeven
2014-03-11 14:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311104713.GN28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®