From: Alexander Gordeev <agordeev@redhat.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Kent Overstreet <kmo@daterainc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH RESEND 1/3] percpu_ida: Fix data race on cpus_have_tags cpumask
Date: Tue, 11 Mar 2014 17:31:24 +0100 [thread overview]
Message-ID: <20140311163123.GC25564@dhcp-26-207.brq.redhat.com> (raw)
In-Reply-To: <CACVXFVMB4YyyEDph5CsVPRLFe4ZncxVrarxV7-VT2wC=pbPTZQ@mail.gmail.com>
On Tue, Mar 11, 2014 at 11:34:21PM +0800, Ming Lei wrote:
> I mean the below block can be put inside the previous lock:
Oh, *now* I see what you mean. Please, ignore my prevous reply.
Still, we want to release the lock as soon as possible and
there is no reason to the below bits it under lock.
> if (nr_free == 1)
> cpumask_set_cpu()
>
> As I mentioned, 'nr_free == 1' doesn't happen frequently, so
> it won't be big deal, will it?
--
Regards,
Alexander Gordeev
agordeev@redhat.com
next prev parent reply other threads:[~2014-03-11 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 12:24 [PATCH RESEND 0/3] percpu_ida: Various tweaks Alexander Gordeev
2014-02-06 12:24 ` [PATCH RESEND 1/3] percpu_ida: Fix data race on cpus_have_tags cpumask Alexander Gordeev
2014-02-26 23:05 ` Kent Overstreet
2014-03-02 14:42 ` Ming Lei
2014-03-11 14:03 ` Alexander Gordeev
2014-03-11 15:34 ` Ming Lei
2014-03-11 15:59 ` Alexander Gordeev
2014-03-11 16:31 ` Alexander Gordeev [this message]
2014-03-12 11:27 ` Ming Lei
2014-02-06 12:24 ` [PATCH RESEND 2/3] percpu_ida: Move waking up waiters out of atomic contexts Alexander Gordeev
2014-02-06 12:24 ` [PATCH RESEND 3/3] percpu_ida: Sanity check initialization parameters Alexander Gordeev
2014-02-26 23:07 ` Kent Overstreet
2014-02-16 11:25 ` [PATCH 4/4] percpu_ida: Do not steal all remote CPU tags at once Alexander Gordeev
2014-02-26 23:08 ` Kent Overstreet
2014-02-26 21:11 ` [PATCH RESEND 0/3] percpu_ida: Various tweaks Alexander Gordeev
2014-02-26 23:01 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311163123.GC25564@dhcp-26-207.brq.redhat.com \
--to=agordeev@redhat.com \
--cc=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=peterz@infradead.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®