mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/fb-helper: Do the 'max_conn_count' zero check
Date: Tue, 11 Mar 2014 21:39:34 +0100	[thread overview]
Message-ID: <20140311203934.GJ30571@phenom.ffwll.local> (raw)
In-Reply-To: <1394415238-20085-1-git-send-email-Li.Xiubo@freescale.com>

On Mon, Mar 10, 2014 at 09:33:58AM +0800, Xiubo Li wrote:
> Since we cannot make sure the 'max_conn_count' will always be none
> zero from the users, and then if max_conn_count equals to zero, the
> kcalloc() will return ZERO_SIZE_PTR, which equals to ((void *)16).
> 
> So this patch fix this with just doing the 'max_conn_count' zero check
> in the front of drm_fb_helper_init().
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> CC: Jani Nikula <jani.nikula@linux.intel.com>

Makes sense.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_fb_helper.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 3d13ca6e2..a0d286c 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -514,6 +514,9 @@ int drm_fb_helper_init(struct drm_device *dev,
>  	struct drm_crtc *crtc;
>  	int i;
>  
> +	if (!max_conn_count)
> +		return -EINVAL;
> +
>  	fb_helper->dev = dev;
>  
>  	INIT_LIST_HEAD(&fb_helper->kernel_fb_list);
> -- 
> 1.8.4
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2014-03-11 20:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  1:33 Xiubo Li
2014-03-11 20:39 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311203934.GJ30571@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=Li.Xiubo@freescale.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®