From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
linux-kernel@vger.kernel.org,
Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: [char-misc-next 3/3] mei: report consistently copy_from/to_user failures
Date: Tue, 11 Mar 2014 21:29:43 +0000 [thread overview]
Message-ID: <20140311212943.3d9541f9@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1394542165-19362-3-git-send-email-tomas.winkler@intel.com>
On Tue, 11 Mar 2014 14:49:25 +0200
Tomas Winkler <tomas.winkler@intel.com> wrote:
> From: Alexander Usyskin <alexander.usyskin@intel.com>
>
> Consistently display error on possible copy_from/to_user failures
> and replace dev_dbg with dev_err
NAK
This allows users to flood the logs by deliberately causing lots of these
failed to copy data error messages, and if they can flood the logs they
can hide other stuff.
The -EFAULT cases should be consistent - but consistently *not* logged.
Alan
next prev parent reply other threads:[~2014-03-11 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:49 [char-misc-next 1/3] mei: make me hw headers private to me hw Tomas Winkler
2014-03-11 12:49 ` [char-misc-next 2/3] mei: drop pr_fmt macros Tomas Winkler
2014-03-11 12:49 ` [char-misc-next 3/3] mei: report consistently copy_from/to_user failures Tomas Winkler
2014-03-11 21:29 ` One Thousand Gnomes [this message]
2014-03-11 22:39 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311212943.3d9541f9@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®