From: Mark Brown <broonie@kernel.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
linux-spi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Chris Zankel <chris@zankel.net>, Marc Gauthier <marc@cadence.com>,
Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] spi: add xtfpga SPI controller driver
Date: Wed, 12 Mar 2014 01:11:16 +0000 [thread overview]
Message-ID: <20140312011116.GJ28112@sirena.org.uk> (raw)
In-Reply-To: <CAMo8Bf+dePYf0jW6zaH-4Qiy5oF-bBzHjkfzL1u6pyTS1OE46w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Wed, Mar 12, 2014 at 04:59:47AM +0400, Max Filippov wrote:
> And tlv320aic23 has the following regmap:
> const struct regmap_config tlv320aic23_regmap = {
> .reg_bits = 7,
> .val_bits = 9,
> and its SPI interface accordingly does the following in .probe:
> spi->bits_per_word = 16
> spi->mode = SPI_MODE_0;
> ret = spi_setup(spi);
So I just looked again - the SPI code isn't in mainline, there must
be some out of tree patches here that can't have been tested since the
driver was converted to regmap (or the byte swapping you're doing in the
controller is buggy for 16 bits per word).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-12 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:44 [PATCH 0/3] xtensa " Max Filippov
2014-03-11 12:44 ` [PATCH 1/3] spi: add " Max Filippov
2014-03-11 19:49 ` Mark Brown
2014-03-11 20:20 ` Max Filippov
2014-03-12 0:34 ` Mark Brown
2014-03-12 0:59 ` Max Filippov
2014-03-12 1:08 ` Mark Brown
2014-03-12 1:43 ` Max Filippov
2014-03-12 1:53 ` Mark Brown
2014-03-12 1:11 ` Mark Brown [this message]
2014-03-12 1:48 ` Max Filippov
2014-03-12 13:24 ` Mark Brown
2014-03-11 12:44 ` [PATCH 2/3] spi/xtensa-xtfpga: add DT binding documentation Max Filippov
2014-03-11 12:44 ` [PATCH 3/3] MAINTAINERS: add xtfpga platform section Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312011116.GJ28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marc@cadence.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®