From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: fix: remove double calculation in fix_small_imbalance
Date: Wed, 12 Mar 2014 10:00:35 +0100 [thread overview]
Message-ID: <20140312090035.GM30956@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1394555166-22894-1-git-send-email-vincent.guittot@linaro.org>
On Tue, Mar 11, 2014 at 05:26:06PM +0100, Vincent Guittot wrote:
> The tmp value has been already calculated in:
> scaled_busy_load_per_task =
> (busiest->load_per_task * SCHED_POWER_SCALE) /
> busiest->group_power;
You created a little confusion in my brain by saying it was a fix; while
in fact it is an optimization removing duplicate computation.
I've changed the Subject to read:
sched: Remove double calculation in fix_small_imbalance
next prev parent reply other threads:[~2014-03-12 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 16:26 Vincent Guittot
2014-03-12 9:00 ` Peter Zijlstra [this message]
2014-03-12 12:56 ` Vincent Guittot
2014-03-12 10:10 ` [tip:sched/core] sched: Remove double calculation in fix_small_imbalance() tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312090035.GM30956@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®