From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878AbaCLPNc (ORCPT ); Wed, 12 Mar 2014 11:13:32 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:47178 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbaCLPNa (ORCPT ); Wed, 12 Mar 2014 11:13:30 -0400 Date: Wed, 12 Mar 2014 15:13:20 +0000 From: Mark Rutland To: Max Filippov Cc: "linux-xtensa@linux-xtensa.org" , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Chris Zankel , Marc Gauthier , Mark Brown , Rob Herring , "grant.likely@linaro.org" , Andrew Morton Subject: Re: [PATCH v2 2/3] spi/xtensa-xtfpga: add DT binding documentation Message-ID: <20140312151320.GB5035@e106331-lin.cambridge.arm.com> References: <1394626865-15105-1-git-send-email-jcmvbkbc@gmail.com> <1394626865-15105-3-git-send-email-jcmvbkbc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394626865-15105-3-git-send-email-jcmvbkbc@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 12, 2014 at 12:21:04PM +0000, Max Filippov wrote: > Signed-off-by: Max Filippov > --- > Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt > new file mode 100644 > index 0000000..b6ebe2b > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-xtensa-xtfpga.txt > @@ -0,0 +1,9 @@ > +Cadence Xtensa XTFPGA platform SPI controller. > + > +This simple SPI master controller is built into xtfpga bitstreams and is used > +to control daughterboard audio codec. > + > +Required properties: > +- compatible: should be "cdns,xtfpga-spi". Is that the official name of the block? Nothing more specific? > +- reg: physical base address of the controller and length of memory mapped > + region. No interrupts? Otherwise, this looks fine to me. Cheers, Mark.